Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux SDL canvas offset bug #2122

Open
wants to merge 5 commits into
base: development
Choose a base branch
from
Open

linux SDL canvas offset bug #2122

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 13, 2017

fixes #2117

Where the canvas was at offset when window resolution was greater than system resolution.

…en window resolution was greater than system resolution.
@Areloch Areloch added the Bugfix label Nov 13, 2017
@ghost
Copy link
Author

ghost commented Nov 13, 2017

As has been pointed out, the padding won't account for a menu bar that uses a font much larger than the standard used in menu for GUI editor and world editor tools. I could call for menu height but no menu exists yet. I suggest we merge the padding hack until I can figure out exactly what the heck is going on with the canvas when a menu is added.

@ghost
Copy link
Author

ghost commented Nov 13, 2017

The hack is no longer necessary.

@ghost
Copy link
Author

ghost commented Nov 13, 2017

New problem resulting from this. Now the offset is positive and only occurs when you resize manually. This is the polar opposite problem of the problem I was attempting to solve in the first place.

@ghost
Copy link
Author

ghost commented Nov 14, 2017

I don't know why the magic number 10 is necessary for it to play nice in gnome and fluxbox but it is. The magic number hack makes for smoother experience on linux than without it at least on those two managers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux SDL canvas offset problem
3 participants